Open
Conversation
srietkerk
reviewed
Apr 7, 2026
| } | ||
|
|
||
| eatWhitespace() { | ||
| while (this.melodyStringIndex < this.melody.length && this.melody.charAt(this.melodyStringIndex) == " ") { |
Contributor
There was a problem hiding this comment.
Same question in the other PR about if this should be a === or not.
srietkerk
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the other part of the fix for microsoft/pxt-microbit#6664
copies over the melody parsing from microsoft/pxt-microbit#6762 and uses it to parse the strings passed into the melody editor. should now allow anything that counts as a valid melody in the note range, e.g.