include special icons for the monaco flyout#11251
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for “brand” (special/font) icons in the Monaco flyout heading so that category icons render with the correct icon font, aligning Monaco flyout visuals with the Blockly toolbox behavior.
Changes:
- Introduces a
brandIconslookup inmonacoFlyout.tsxto detect brand-font glyphs. - Applies a conditional
brandIconCSS class to the Monaco flyout heading icon when the icon is a brand glyph.
jwunderl
approved these changes
Apr 8, 2026
| const { name, ns, color, icon, groups, selectedBlock } = this.state; | ||
| const rgb = pxt.toolbox.getAccessibleBackground(pxt.toolbox.convertColor(color || (ns && pxt.toolbox.getNamespaceColor(ns)) || "255")); | ||
| const iconClass = `blocklyTreeIcon${icon ? (ns || icon).toLowerCase() : "Default"}`.replace(/\s/g, ""); | ||
| const isBrandIcon = icon && icon in brandIcons; |
Member
There was a problem hiding this comment.
teeny but in has some weird semantics / typically lean towards avoiding in favor of .hasOwnProperty. Almost certainly shouldn't impact anything in this case so feel free to ignore if don't feel like it~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#6754