Export as PNG and Github #11094
Export as PNG and Github #11094
Conversation
|
Thanks @Kikketer for contribution. |
|
|
||
| let downloadButtonClasses = ""; | ||
| let saveButtonClasses = ""; | ||
| if (isSaving) { |
There was a problem hiding this comment.
What is the need for this section of code removal? If I remember correctly this so that kids don't smash bunch of buttons when saving is in progress.
There was a problem hiding this comment.
Pull request overview
This PR enables simultaneous saving of projects as both PNG files and to GitHub, removing the previous exclusivity between these two export options.
Changes:
- Removed GitHub repository check that prevented PNG export for GitHub-linked projects
- Cleaned up unused variables related to save/download button state management
| return <div id="editortools" className="ui" role="region" aria-label={lf("Editor toolbar")}> | ||
| <div id="downloadArea" role="menubar" className="ui column items"> | ||
| {showCompileBtn && <div className="ui item portrait hide"> |
There was a problem hiding this comment.
The removed variables downloadButtonClasses and saveButtonClasses appear to have been used for managing button states during save/compile operations. Verify that button state management (disabled/loading states) is handled elsewhere in the component to prevent users from triggering multiple simultaneous operations.
3 participants
A simple modification and cleanup to allow saving as PNG and Github at the same time.
More than once I'd had a situation where I keep an application in github for version control, publishing, etc. but then also need the ease of sharing the PNG file for others to import and learn from.
Note: I don't see the whole picture, this modifies the root pxt framework so I would understand if this doesn't jive well with the other dependencies.
Note Note: I wasn't able to test this locally due to
localhostand the github key handling where I'm not able to link github with localhost, I'm sure this path is possible to test but I'm not aware of how.