add public methods for Load(Stream...) and LoadAsync(Stream,...), inc…#207
Closed
rysweet wants to merge 4 commits intomicrosoft:mainfrom
Closed
add public methods for Load(Stream...) and LoadAsync(Stream,...), inc…#207rysweet wants to merge 4 commits intomicrosoft:mainfrom
rysweet wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Author
|
I wasn't sure where to add doc, if any |
Closed
markwallace-microsoft
approved these changes
Mar 13, 2025
Contributor
markwallace-microsoft
left a comment
markwallace-microsoft
left a comment
There was a problem hiding this comment.
Aside from the warnings flagged LGTM
Author
I'm not seeing warnings - happy to track them down just not sure where you are seeing them ;-) |
markwallace-microsoft
previously approved these changes
Mar 13, 2025
Author
found and fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds public methods for Load(Stream...) and LoadAsync(Stream,...) and tests for each.
This enables you to include prompty files as an embedded resource in the dll and reference them as a Stream.
This closes #206