Skip to content

test(dashboard): wait for page load before asserting in annotate tests #40739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SebTardif wants to merge 1 commit into from
+13 −0
Closed

test(dashboard): wait for page load before asserting in annotate tests #40739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/mcp/annotate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ test('should capture multiple screenshots in one annotation', async ({ connectTo
const browser = await connectToDashboard(bindTitle);

const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await dashboard.getByRole('navigation', { name: 'Sessions' }).getByRole('option').first().click();

const annotatePromise = cli('show', '--annotate');
Expand Down Expand Up @@ -114,6 +115,7 @@ test('should abort annotation when last screenshot is removed', async ({ connect
const browser = await connectToDashboard(bindTitle);

const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await dashboard.getByRole('navigation', { name: 'Sessions' }).getByRole('option').first().click();

const annotatePromise = cli('show', '--annotate');
Expand Down Expand Up @@ -153,6 +155,7 @@ test('should abort MCP annotation when last screenshot is removed', async ({ con
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.locator('.annotate-sidebar-thumb')).toHaveCount(1);

// Close the fullscreen overlay first so the sidebar remove button is accessible.
Expand All @@ -177,6 +180,7 @@ test('user-initiated annotate downloads zip with feedback.md', async ({ connectT
const browser = await connectToDashboard(bindTitle);

const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await dashboard.getByRole('navigation', { name: 'Sessions' }).getByRole('option').first().click();

// Start with an aborting picker to verify cancellation keeps the session intact.
Expand Down Expand Up @@ -234,6 +238,7 @@ test('should capture annotations via show --annotate', async ({ connectToDashboa
const browser = await connectToDashboard(bindTitle);

const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await dashboard.getByRole('navigation', { name: 'Sessions' }).getByRole('option').first().click();

const annotatePromise = cli('show', '--annotate');
Expand All @@ -259,6 +264,7 @@ test('should start dashboard and annotate when no dashboard is running', async (
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await drawAndSubmitAnnotation(dashboard, 'hi');
} finally {
await browser.close().catch(() => {});
Expand All @@ -282,6 +288,7 @@ test('should enter annotate mode on fresh dashboard.tsx mount with -s --annotate
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.getByRole('main', { name: 'Dashboard: annotate' })).toBeVisible();
await expect(activeSession(dashboard)).toHaveAccessibleName('Session second');
await drawAndSubmitAnnotation(dashboard, 'fresh');
Expand Down Expand Up @@ -314,6 +321,7 @@ test('should annotate via direct browser_annotate MCP call', async ({ connectToD
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.getByRole('main', { name: 'Dashboard: annotate' })).toBeVisible();
await drawAndSubmitAnnotation(dashboard, 'direct-mcp');
} finally {
Expand Down Expand Up @@ -351,6 +359,7 @@ test('should annotate when context has no fixed viewport', async ({ connectToDas
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.getByRole('main', { name: 'Dashboard: annotate' })).toBeVisible();
await drawAndSubmitAnnotation(dashboard, 'no-viewport');
} finally {
Expand Down Expand Up @@ -383,6 +392,7 @@ test('should cancel browser_annotate when the MCP request is aborted', async ({
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.getByRole('main', { name: 'Dashboard: annotate' })).toBeVisible();

controller.abort();
Expand Down Expand Up @@ -413,6 +423,7 @@ test('should cancel browser_annotate when the MCP client disconnects', async ({
const browser = await connectToDashboard(bindTitle);
try {
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.getByRole('main', { name: 'Dashboard: annotate' })).toBeVisible();

await client.close();
Expand All @@ -435,6 +446,7 @@ test('should switch screencast to -s session on show --annotate', async ({ conne
await cli('-s=first', 'show', { bindTitle });
const browser = await connectToDashboard(bindTitle);
const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await expect(dashboard.locator('#display')).toBeVisible();

const sampleCenter = () => dashboard.evaluate(() => {
Expand Down Expand Up @@ -480,6 +492,7 @@ test('should disengage annotate mode when --annotate client disconnects', async
const browser = await connectToDashboard(bindTitle);

const dashboard = browser.contexts()[0].pages()[0];
await dashboard.waitForLoadState('load');
await dashboard.getByRole('navigation', { name: 'Sessions' }).getByRole('option').first().click();

const annotateClient = childProcess({
Expand Down