test(dashboard): bump timeout for in-flight Submit re-enable assertion#40729
Draft
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Draft
test(dashboard): bump timeout for in-flight Submit re-enable assertion#40729Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Experiment to test the hypothesis that the on-page submit pipeline (PNG render per frame + zip build + picker reject) can take longer than the default 5s expect-poll on slow CI shards, leaving the Submit button stuck on "Submitting…" when the assertion fires. Observed in https://github.com/microsoft/playwright/actions/runs/25559486702 where the error-context aria snapshot showed `button "Submitting…" [disabled]` at the moment of timeout.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"6 failed 7025 passed, 1068 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experiment to test the hypothesis that the in-flight submit pipeline can outlast the default 5s expect-poll on slow CI, leaving the Submit button stuck on "Submitting…" when the assertion fires.
Seen in https://github.com/microsoft/playwright/actions/runs/25559486702 — error-context aria snapshot at timeout shows
button "Submitting…" [disabled].Draft to see if the bump alone makes this shard happy; if so, real fix is to await the in-flight work (or match both labels) rather than carry a longer timeout.