Skip to content

chore: move expect log statements out of frame/page into dispatchers#40727

Open
dgozman wants to merge 1 commit intomicrosoft:mainfrom
dgozman:chore-render-title-for-call
Open

chore: move expect log statements out of frame/page into dispatchers#40727
dgozman wants to merge 1 commit intomicrosoft:mainfrom
dgozman:chore-render-title-for-call

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented May 8, 2026

Summary

  • Move progress.log(renderTitleForCall(...)) from Frame.expect and Page.expectScreenshot to their dispatcher callsites, dropping renderTitleForCall imports from playwright-core/src/server/frames.ts and page.ts.
  • Drop the now-unused timeoutForLogs field from FrameExpectParams.

Removes `renderTitleForCall` usage from `playwright-core/src/server/frames.ts`
and `playwright-core/src/server/page.ts` by moving the action-title `progress.log`
calls in `Frame.expect` and `Page.expectScreenshot` to their dispatcher callsites.

Also drops the now-unused `timeoutForLogs` field from `FrameExpectParams`.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Test results for "MCP"

8 failed
❌ [chromium] › mcp/annotate.spec.ts:137 › should abort MCP annotation when last screenshot is removed @mcp-windows-latest-chromium
❌ [firefox] › mcp/cli-devtools.spec.ts:217 › video-start-stop @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:231 › video-chapter @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:177 › close-all after open returns closed sessions @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:123 › daemon show: closing page exits the process @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:159 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit

7023 passed, 1068 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@ubuntu-latest-node22`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:185 › should watch new file `@ubuntu-latest-node22`

41692 passed, 850 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant