Skip to content

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Jan 25, 2026

Fixes #38901

@yury-s yury-s requested a review from dgozman January 25, 2026 20:37
@github-actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@windows-latest-node20`

34669 passed, 695 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

96 failed
❌ [chrome] › mcp/config.spec.ts:82 › sandbox configuration › should enable sandbox by default (no --no-sandbox flag) @mcp-ubuntu-latest
❌ [chromium] › mcp/config.spec.ts:82 › sandbox configuration › should enable sandbox by default (no --no-sandbox flag) @mcp-ubuntu-latest
❌ [firefox] › mcp/config.spec.ts:82 › sandbox configuration › should enable sandbox by default (no --no-sandbox flag) @mcp-ubuntu-latest
❌ [webkit] › mcp/config.spec.ts:82 › sandbox configuration › should enable sandbox by default (no --no-sandbox flag) @mcp-ubuntu-latest
❌ [chrome] › mcp/cli.spec.ts:48 › core › click button @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:71 › core › dblclick @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:87 › core › fill @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:96 › core › hover @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:112 › core › check @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:160 › core › dialog-dismiss @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:179 › core › resize @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:197 › navigation › go-forward @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:249 › mouse › mousewheel @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:315 › devtools › console --clear @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:324 › devtools › network @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:333 › devtools › network --static @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:416 › session › session-stop @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:464 › session › session-delete named session @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:58 › core › click link @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:71 › core › dblclick @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:130 › core › eval @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:149 › core › dialog-accept @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:160 › core › dialog-dismiss @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:170 › core › dialog-accept @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:188 › navigation › go-back @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:197 › navigation › go-forward @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:209 › keyboard › press @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:249 › mouse › mousewheel @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:265 › save as › screenshot @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:272 › save as › screenshot @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:280 › save as › screenshot --full-page @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:287 › save as › pdf @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:305 › devtools › console error @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:324 › devtools › network @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:340 › devtools › network --clear @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:366 › config › user-data-dir @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:438 › session › session-stop-all @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:33 › core › open @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:42 › core › close @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:48 › core › click button @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:78 › core › type @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:87 › core › fill @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:96 › core › hover @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:121 › core › uncheck @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:142 › core › eval @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:149 › core › dialog-accept @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:170 › core › dialog-accept @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:179 › core › resize @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:197 › navigation › go-forward @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:249 › mouse › mousewheel @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:265 › save as › screenshot @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:272 › save as › screenshot @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:280 › save as › screenshot --full-page @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:315 › devtools › console --clear @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:340 › devtools › network --clear @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:377 › config › context options @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:391 › config › isolated @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:426 › session › session-stop named session @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:438 › session › session-stop-all @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:452 › session › session-delete @mcp-windows-latest
❌ [firefox] › mcp/cli.spec.ts:464 › session › session-delete named session @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:33 › core › open @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:58 › core › click link @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:112 › core › check @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:121 › core › uncheck @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:136 › core › eval no arrow @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:230 › mouse › mousemove @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:249 › mouse › mousewheel @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:280 › save as › screenshot --full-page @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:333 › devtools › network --static @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:340 › devtools › network --clear @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:355 › devtools › tracing-start-stop @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:464 › session › session-delete named session @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:58 › core › click link @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:112 › core › check @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:142 › core › eval @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:149 › core › dialog-accept @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:179 › core › resize @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:238 › mouse › mousedown mouseup @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:249 › mouse › mousewheel @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:265 › save as › screenshot @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:305 › devtools › console error @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:324 › devtools › network @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:340 › devtools › network --clear @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:355 › devtools › tracing-start-stop @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:426 › session › session-stop named session @mcp-windows-latest
❌ [msedge] › mcp/cli.spec.ts:438 › session › session-stop-all @mcp-windows-latest

3350 passed, 116 skipped


Merge workflow run.

@dgozman
Copy link
Contributor

dgozman commented Jan 26, 2026

I don't think we can afford this, there are still too many users on Node 18.

@dominik-niebuhr
Copy link

I don't think we can afford this, there are still too many users on Node 18.

@dgozman
Playwrights docs state at least Node 20 required, so fix this instead?
https://playwright.dev/docs/intro#system-requirements:~:text=Node.js%3A%20latest%2020.x%2C%2022.x%20or%2024.x.

@yury-s
Copy link
Member Author

yury-s commented Jan 26, 2026

Let's wait until 26 is out. There are still many users on 18, even though we don't officially support 18 anymore, we don't want to break them for no reason either.

@yury-s yury-s closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Update the Node version to 20 in package.json

3 participants