Skip to content

fix: don't parse file names for tags #38949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yury-s wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't parse file names for tags #38949

yury-s wants to merge 1 commit into from
+60 −1

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Jan 25, 2026

File names containing @ symbols (e.g., @sample.test.ts) were incorrectly being treated as tags. Now only extract inline tags from describe block titles and test titles, not from file/project/root suite titles.

Fixes #38946

@yury-s
fix: don't parse file names for tags
2f629a4 
File names containing @ symbols (e.g., @sample.test.ts) were incorrectly
being treated as tags. Now only extract inline tags from describe block
titles and test titles, not from file/project/root suite titles.

Fixes microsoft#38946
@yury-s yury-s requested a review from dgozman January 25, 2026 05:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

Test results for "tests 1"

12 failed
❌ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight
❌ [playwright-test] › playwright.trace.spec.ts:345 › should retain traces for interrupted tests @macos-latest-node20
❌ [playwright-test] › test-tag.spec.ts:19 › should have correct tags @ubuntu-latest-node20
❌ [playwright-test] › test-tag.spec.ts:169 › should be included in testInfo if coming from describe or global tag @ubuntu-latest-node20
❌ [playwright-test] › test-tag.spec.ts:19 › should have correct tags @macos-latest-node20
❌ [playwright-test] › test-tag.spec.ts:169 › should be included in testInfo if coming from describe or global tag @macos-latest-node20
❌ [playwright-test] › test-tag.spec.ts:19 › should have correct tags @ubuntu-latest-node24
❌ [playwright-test] › test-tag.spec.ts:169 › should be included in testInfo if coming from describe or global tag @ubuntu-latest-node24
❌ [playwright-test] › test-tag.spec.ts:19 › should have correct tags @ubuntu-latest-node22
❌ [playwright-test] › test-tag.spec.ts:169 › should be included in testInfo if coming from describe or global tag @ubuntu-latest-node22
❌ [playwright-test] › test-tag.spec.ts:19 › should have correct tags @windows-latest-node20
❌ [playwright-test] › test-tag.spec.ts:169 › should be included in testInfo if coming from describe or global tag @windows-latest-node20

7 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:385 › should reveal errors in the sourcetab `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:701 › should indicate current test status `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:385 › should reveal errors in the sourcetab `@windows-latest-node20`

34659 passed, 695 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

Test results for "MCP"

9 failed
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:274 › save as › screenshot --full-page
❌ [chromium] › mcp/cli.spec.ts:169 › core › dialog-accept
❌ [chromium] › mcp/cli.spec.ts:274 › save as › screenshot --full-page
❌ [chromium] › mcp/cli.spec.ts:349 › devtools › tracing-start-stop
❌ [firefox] › mcp/cli.spec.ts:274 › save as › screenshot --full-page
❌ [firefox] › mcp/cli.spec.ts:349 › devtools › tracing-start-stop
❌ [webkit] › mcp/cli.spec.ts:274 › save as › screenshot --full-page
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15

3105 passed, 305 skipped

Merge workflow run.

dgozman
dgozman reviewed Jan 25, 2026
View reviewed changes
packages/playwright/src/common/test.ts

get tags(): string[] {
const titleTags = this._grepBaseTitlePath().join(' ').match(/@[\S]+/g) || [];
// Only extract inline tags from describe blocks and test title, not from file/project/root titles.
Copy link
Contributor

@dgozman dgozman Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just pop first two items from this._grepBaseTitlePath()? These would be project + file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Test files with '@' in the name produce unexpected tags

2 participants

@yury-s @dgozman