fix(fixtures): prevent a fixture named "then" from being awaited #38948
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanrieu
changed the title
joanrieu
force-pushed
the
fix-fixtures-thenable
branch
from
1024f81 to
97f42b1
Compare
joanrieu
force-pushed
the
fix-fixtures-thenable
branch
from
97f42b1 to
15c3498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a fixture named
thenwith a function value would make the entire test parameters object be incorrectly treated as a Promise by async/await, causing unexpected behaviour of the test runner.The fix changes the internal representation of test parameters (the resolved fixtures) from a plain object to a Map, which is converted to an object only when passed to the test function. This prevents the name and type of fixtures from having any impact on the test runner's behaviour.
Fixes #38828