Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 23, 2026

  • Make cli depend on daemon.
  • Use childProcess fixture to avoid zombies.

@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the test-mcp-cli-common-fixtures branch from 42ccfa7 to 53a77ee Compare January 23, 2026 15:24
- Make `cli` depend on `daemon`.
- Use `childProcess` fixture to avoid zombies.
@dgozman dgozman force-pushed the test-mcp-cli-common-fixtures branch from 53a77ee to 45dfe5a Compare January 23, 2026 15:49
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

5 failed
❌ [playwright-test] › playwright.trace.spec.ts:1119 › trace:retain-on-first-failure should create trace if context is closed before failure in afterEach @macos-latest-node20
❌ [playwright-test] › reporter-markdown.spec.ts:158 › report with annotations @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:301 › should copy network request @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:264 › should toggle sections inside network details @windows-latest-node20

2 flaky ⚠️ [webkit-page] › page/page-autowaiting-basic.spec.ts:79 › should await form-post on click `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`

34666 passed, 695 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

9 failed
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:162 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15

3097 passed, 300 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant