Skip to content

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Jan 22, 2026

Fixes the following tests:

  • library/permissions.spec.ts:
    • "should deny permission when not listed" (with BiDi, permissions that were not granted remain in 'prompt' state instead of changing to 'denied')
    • "should fail when bad permission is given" (the error message is different with BiDi)
    • "should trigger permission onchange" (with BiDi, permissions that were not granted remain in 'prompt' state instead of changing to 'denied')
    • "should isolate permissions between browser contexts" (with BiDi, permissions that were not granted remain in 'prompt' state instead of changing to 'denied')
  • page/page-wait-for-load-state.spec.ts:
    • "should wait for load state of empty url popup" (Firefox/BiDi behaves like other browsers, unlike Firefox/Juggler)

Skips the following tests:

  • library/download.spec.ts:
    • "should be able to download a inline PDF file via navigation" (like headed Chromium, the file is shown in the PDF viewer instead of being downloaded)

Unskips the following tests:

  • library/capabilities.spec.ts:
    • "should play video" (the Firefox issue seems to have been fixed)
  • page/page-focus.spec.ts:
    • "clicking checkbox should activate it" (the test fails only in Safari)

@github-actions
Copy link
Contributor

Test results for "MCP"

2819 passed, 106 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:252 › should toggle sections inside network details @windows-latest-node20

6 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:183 › should show snapshots for steps `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@ubuntu-latest-node22`

34668 passed, 693 skipped


Merge workflow run.

@yury-s yury-s merged commit b08a8f3 into microsoft:main Jan 26, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants