test: use role based selectors in trace-viewer tests #36295
Conversation
mxschmitt
force-pushed
the
improve-trace-viewer-tests
branch
from
229eb3e to
e57d0af
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
improve-trace-viewer-tests
branch
from
e57d0af to
9afd65f
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
improve-trace-viewer-tests
branch
from
9afd65f to
77533e8
Compare
This comment has been minimized.
This comment has been minimized.
| @step | ||
| async selectAction(title: string, ordinal: number = 0) { | ||
| await this.page.locator(`.action-title:has-text("${title}")`).nth(ordinal).click(); | ||
| await this.actionsTree.getByTitle(title).nth(ordinal).click(); |
There was a problem hiding this comment.
Why not getByRole('treeitem', { name: title }) as in previous method?
There was a problem hiding this comment.
The issue is that we have a nested 'treeitem' - so if we don't make it narrower, it clicks in the middle of the 3 items vs. on the page.goto treeitem which is what we want. Do you have a better alternative in mind?
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| stackFrames(selected?: boolean) { | ||
| const entry = this.page.getByRole('list', { name: 'Stack trace' }).getByRole('listitem'); |
There was a problem hiding this comment.
Ideally, we pass { selected } into getByRole. Perhaps we are missing aria-selected somewhere?
There was a problem hiding this comment.
aria-selected is unfortunately not valid on listitems: https://www.w3.org/TR/wai-aria-1.2/#aria-selected
We then throw that its not valid (we add aria-listed on the listitem).
There was a problem hiding this comment.
Interesting 😄 I guess it should be aria-current then, but we don't have an option for this in getByRole().
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Max Schmitt <max@schmitt.mx>
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky39405 passed, 822 skipped Merge workflow run. |
Signed-off-by: Max Schmitt <max@schmitt.mx> Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2 participants
Addresses the comments from microsoft/playwright-python#2885 (review).