Fix for S360/SFI alerts #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses SFI (Security for Infrastructure) alerts by adding a CodeQL justification comment and updating Argo workflows from version 3.7.1 to 3.7.2.
- Added CodeQL justification comment for SSL verification bypass in CosmosDB emulator connection
- Updated Argo workflows version from 3.7.1 to 3.7.2 across deployment documentation and configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pctasks/dev/pctasks/dev/cosmosdb.py | Added CodeQL justification comment for SSL verification bypass |
| docs/development/deploying.md | Updated Argo workflows version references in documentation |
| deployment/helm/argo-values.yaml | Updated image tags to use Argo workflows v3.7.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| while True: | ||
| try: | ||
| resp = requests.get(url, verify=False) | ||
| resp = requests.get(url, verify=False) # CodeQL [SM03157] justification |
There was a problem hiding this comment.
The CodeQL justification comment lacks explanation of why SSL verification is disabled. Consider adding a brief explanation like '# CodeQL [SM03157] SSL verification disabled for local emulator connection' to provide context for reviewers and future maintainers.
Suggested change
| resp = requests.get(url, verify=False) # CodeQL [SM03157] justification | |
| resp = requests.get(url, verify=False) # CodeQL [SM03157] SSL verification disabled for local emulator connection |
gmoralessanchez
approved these changes
Oct 15, 2025
ghidalgo3
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes on this PR were to address the SFI alerts which is an ongoing effort within Microsoft.