Skip to content

refactor(cargo-heather): replace tracing with println#34

Merged
Vaiz merged 1 commit into
mainfrom
u/vaiz/drop-tracing
May 29, 2026
Merged

refactor(cargo-heather): replace tracing with println#34
Vaiz merged 1 commit into
mainfrom
u/vaiz/drop-tracing

Conversation

@Vaiz
Copy link
Copy Markdown
Contributor

@Vaiz Vaiz commented May 28, 2026

cargo-heather used tracing only for user-facing info!() output with all structured-logging features disabled (no levels, no targets, no timestamps, no spans). Replace with plain println!() and drop tracing + tracing-subscriber from both the crate and the workspace.

This removes 9 transitive crates (tracing, tracing-core, tracing-subscriber, sharded-slab, thread_local, lazy_static, pin-project-lite, once_cell, cfg-if) from the dependency tree

cargo-heather used tracing only for user-facing `info!()` output with
all structured-logging features disabled (no levels, no targets, no
timestamps, no spans). Replace with plain `println!()` and drop
`tracing` + `tracing-subscriber` from both the crate and the workspace.

This removes 9 transitive crates (tracing, tracing-core, tracing-subscriber,
sharded-slab, thread_local, lazy_static, pin-project-lite, once_cell, cfg-if)
from the dependency tree and ~68 lines from Cargo.lock.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.0%. Comparing base (17e35dc) to head (23cf173).

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #34     +/-   ##
=======================================
- Coverage   90.0%   90.0%   -0.1%     
=======================================
  Files         15      15             
  Lines        808     805      -3     
=======================================
- Hits         728     725      -3     
  Misses        80      80             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vaiz Vaiz marked this pull request as ready for review May 28, 2026 08:13
Copilot AI review requested due to automatic review settings May 28, 2026 08:13
@Vaiz Vaiz enabled auto-merge (squash) May 28, 2026 08:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies cargo-heather CLI output by replacing tracing-based user-facing messages with direct println!() calls and removing the now-unused logging dependencies from the crate and workspace.

Changes:

  • Removed tracing initialization from the cargo-heather binary entry point.
  • Replaced info!() calls with println!() in CLI run/config flows.
  • Removed tracing and tracing-subscriber dependencies and associated lockfile entries.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/cargo-heather/src/bin/cargo-heather/run.rs Replaces progress and result log output with println!().
crates/cargo-heather/src/bin/cargo-heather/main.rs Removes tracing subscriber setup from startup.
crates/cargo-heather/src/bin/cargo-heather/config.rs Replaces fallback config message with println!().
crates/cargo-heather/Cargo.toml Drops crate-level tracing dependencies.
Cargo.toml Drops workspace tracing dependency declarations.
Cargo.lock Removes unused tracing-related packages from the lockfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Vaiz Vaiz merged commit 6109c47 into main May 29, 2026
26 checks passed
@Vaiz Vaiz deleted the u/vaiz/drop-tracing branch May 29, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants