[DO NOT REVIEW]: [MLAS] Hoist some input channel invariant code above a loop in the NCHWc conv#27792
Open
hariharans29 wants to merge 2 commits intomainfrom
Open
[DO NOT REVIEW]: [MLAS] Hoist some input channel invariant code above a loop in the NCHWc conv#27792hariharans29 wants to merge 2 commits intomainfrom
hariharans29 wants to merge 2 commits intomainfrom
Conversation
hariharans29
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the MLAS NCHWc direct-convolution path by moving output-row–dependent kernel-parameter setup out of the per-input-channel-block loop, reducing redundant effective-kernel computation when processing multiple input-channel blocks.
Changes:
- Reordered loops to iterate output rows (
work) before iterating input-channel blocks (ic). - Hoisted
ComputeEffectiveKernel(...)so it executes once per output row and is reused across allicblocks for that row.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hariharans29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title
Motivation and Context
Avoid redundant metadata setup