-
Notifications
You must be signed in to change notification settings - Fork 55
Update Go to 1.25 and CodeQL workflow #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot can you fix the lint build error |
- Add tidy dependency to golangci-lint target - Remove cached golangci-lint binary before reinstall - Clear Go build cache to force recompilation with correct Go version Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot can you retain go.sum |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Remove go.sum from .gitignore to track it in git - Revert tidy dependencies from all, bootstrap, unittest, and mocks targets - Keep tidy dependency on golangci-lint target (needed for lint fix) - Regenerate go.sum with Go 1.25 dependencies Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
Done in commit 6bf258b. The go.sum file is now tracked in the repository with Go 1.25 dependencies. Removed go.sum from .gitignore and reverted the automatic tidy dependencies from most Makefile targets (kept it only for golangci-lint which needs it for the build fix). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot can you fix the error |
|
@copilot can you also fix CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/ |
- Update github/codeql-action from v2 to v3 (init, autobuild, analyze) - Update actions/checkout from v3 to v4 - Fixes CodeQL configuration compatibility warning Co-authored-by: madhanrm <20309044+madhanrm@users.noreply.github.com>
Fixed in commit 5f212dd. Updated the CodeQL workflow to use v3 actions (from v2) and updated the checkout action to v4. This resolves the configuration compatibility issue where GitHub code scanning couldn't find the matching configuration between the PR and main branch. |
Already fixed in commit 5f212dd. All CodeQL actions have been updated from v2 to v3 (init@v3, autobuild@v3, analyze@v3). The checkout action was also updated to v4. This addresses the deprecation warning mentioned in the GitHub changelog. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Go Version Update
GoTool@0tasks to version 1.25.3Lint Build Fix
tidydependency to ensure go.sum is up-to-date before lintingCodeQL Workflow Update
github/codeql-actionfrom v2 to v3 (init, autobuild, analyze steps)actions/checkoutfrom v3 to v4Testing
The go.sum file is tracked in the repository and contains the dependency checksums for Go 1.25.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.