fix: handle None return from llm_caption in PptxConverter#1676
Open
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: handle None return from llm_caption in PptxConverter#1676octo-patch wants to merge 1 commit intomicrosoft:mainfrom
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1534
Problem
llm_caption()is typed asUnion[None, str]and can returnNonein two cases:message.contentisNone(some models can return this)After the
try/exceptblock, the code does:If
llm_descriptionisNone, this raises:Solution
Add
or ""to thellm_caption()call so that aNonereturn value falls back to the initialized default of"":This is a one-character change that makes the behavior consistent: whether
llm_captionraises an exception (caught byexcept) or returnsNone,llm_descriptionremains an empty string.Testing
The fix is minimal and targets the exact line reported in the issue. The downstream
str.join()call now works correctly in all cases:None→ treated as empty string (same as exception path)llm_descriptionstays""(existing behavior)