fix: kill orphaned irqbalance process before waiting for result#4339
Merged
fix: kill orphaned irqbalance process before waiting for result#4339
Conversation
When verify_irqbalance runs `irqbalance --debug` via execute_async with sudo=True, spur internally wraps the command as `sudo sh -c 'irqbalance --debug'`. The PID tracked by LISA belongs to the sudo/sh wrapper, not to irqbalance itself. Fix by explicitly killing irqbalance by name after kill(), ensuring the PTY channel closes before wait_result() is called. Pass raise_on_timeout=False to handle any residual channel-close latency without raising a spurious exception,
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the verify_irqbalance test where irqbalance --debug launched via execute_async with sudo=True could survive as an orphan process after the spur-tracked wrapper process (sudo/sh) was killed. The fix explicitly kills irqbalance by name before calling wait_result(), and uses raise_on_timeout=False to gracefully handle any residual channel-close latency.
Changes:
- Added
Killtool import and usedKill.by_name("irqbalance")afterirqbalance.kill()to ensure the orphaned irqbalance process is terminated - Changed
wait_result()to passraise_on_timeout=Falseso timeout from channel-close latency doesn't raise a spurious exception
You can also share your feedback on Copilot code review. Take the survey.
johnsongeorge-w
added
🛑 DO-NOT-MERGE
⚠️ PR-UNDER-TEST
and removed
⚠️ PR-UNDER-TEST
labels
LiliDeng
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verify_irqbalance runs
irqbalance --debugvia execute_async with sudo=True, spur internally wraps the command assudo sh -c 'irqbalance --debug'. The PID tracked by LISA belongs to the sudo/sh wrapper, not to irqbalance itself.Fix by explicitly killing irqbalance by name after kill(), ensuring the PTY channel closes before wait_result() is called. Pass raise_on_timeout=False to handle any residual channel-close latency without raising a spurious exception,