Patch RetryHandler.tryParseTimeHeader to support comma separated values returned by the server #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values returned by the server
Contributor
Author
|
@microsoft-github-policy-service agree |
baywet
requested changes
Aug 7, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you please add a unit test to prevent future regressions?
Contributor
Author
|
Hi @baywet and thanks for looking into! I've added a parameterized test for the changed method. Looks ok or shall I do any changes? |
alexzayats
force-pushed
the
patch-retry-handler
branch
from
65771b9 to
98a1ec2
Compare
baywet
previously approved these changes
Aug 7, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Member
|
@alexzayats can you please run |
auto-merge was automatically disabled
August 7, 2025 14:22
Head branch was pushed to by a user without write access
Contributor
Author
|
@baywet sure! Done. |
baywet
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2005
Kindly, let me know if the patch needs any changes.