fix: preserve nodes with unassigned community level in filtering#2259
Open
Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: preserve nodes with unassigned community level in filtering#2259Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Br1an67 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Modify _filter_under_community_level to retain nodes where level is NaN, which represent isolated nodes not assigned to any community by the Leiden algorithm. Previously these nodes were silently dropped because NaN comparisons always evaluate to False in pandas. Fixes microsoft#1808
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
_filter_under_community_levelto retain nodes wherelevelis NaN, which represent isolated nodes not assigned to any community by the Leiden algorithm. Previously these nodes were silently dropped because NaN comparisons always evaluate to False in pandas, causing approximately 10% data loss.Related Issues
Fixes #1808
Proposed Changes
| df.level.isna()condition to_filter_under_community_levelso NaN-level nodes are preservedChecklist
Additional Notes
Downstream code already handles NaN community values with
fillna(-1), so preserving these nodes is consistent with the existing data flow.