docs: document systemcrypto experiment removal#2337
Open
qmuntal wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft build of Go documentation to reflect that systemcrypto/nosystemcrypto are no longer configured via GOEXPERIMENT starting in Go 1.27, and to document the MS_GO_NOSYSTEMCRYPTO=1 opt-out plus the Go 1.27 Linux CGO_ENABLED=0 (cgo-less OpenSSL) behavior.
Changes:
- Replaces/clarifies user guidance around
GOEXPERIMENT=systemcrypto/GOEXPERIMENT=nosystemcryptoremoval and theMS_GO_NOSYSTEMCRYPTO=1opt-out. - Updates no-cgo OpenSSL backend docs to describe Go 1.27+ automatic selection behavior (and Go 1.26’s experimental flag).
- Updates FIPS, migration, toolset-identification, and telemetry docs for consistency with the new configuration model.
Show a summary per file
| File | Description |
|---|---|
| eng/doc/Telemetry.md | Clarifies what the msgo/systemcrypto:{enabled,disabled} telemetry counter represents (default selection + MS_GO_NOSYSTEMCRYPTO=1 opt-out). |
| eng/doc/NocgoOpenSSL.md | Updates the narrative to describe Go 1.27+ automatic cgo-less OpenSSL selection on Linux and notes the removed Go 1.26 experiment. |
| eng/doc/MigrationGuide.md | Updates migration guidance for Go 1.27+ removal of systemcrypto/nosystemcrypto from GOEXPERIMENT, and documents the no-cgo Linux behavior. |
| eng/doc/MicrosoftToolsetIdentification.md | Adjusts identification guidance to account for GOEXPERIMENT=systemcrypto/nosystemcrypto only being present in older binaries. |
| eng/doc/fips/README.md | Reframes build configuration guidance around default selection + MS_GO_NOSYSTEMCRYPTO=1, retaining legacy build-tag compatibility notes. |
| eng/doc/AdditionalFeatures.md | Updates the high-level feature overview to match Go 1.27’s configuration approach and opt-out mechanism. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents PR 2320 follow-up:
Validation: