Skip to content

Changed trailingIcon type from val to var #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartikeyakhanna wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed trailingIcon type from val to var #811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e776d7
Changed trailingIcon type from val to var
kartikeyakhanna Dec 15, 2025
5bf9e96
dummy commit
kartikeyakhanna Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...fication/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ data class SnackBarItemModel(
val id: String = java.util.UUID.randomUUID().toString(),
val style: SnackbarStyle = SnackbarStyle.Neutral,
val leadingIcon: FluentIcon? = null,
val trailingIcon: FluentIcon? = null,
var trailingIcon: FluentIcon? = null,
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing trailingIcon from val to var in a data class marked with @Stable is problematic. The @Stable annotation tells Compose that the object is immutable, but introducing a mutable property violates this contract. This can lead to recomposition issues where changes to the trailingIcon won't trigger proper UI updates. Consider creating a new instance of the model with the updated trailingIcon using the data class copy() method instead of mutating the property.

Suggested change
var trailingIcon: FluentIcon? = null,
val trailingIcon: FluentIcon? = null,

Copilot uses AI. Check for mistakes.
val subTitle: String? = null,
val actionText: String? = null,
val snackBarToken: StackableSnackBarTokens = DEFAULT_SNACKBAR_TOKENS,
Expand Down Expand Up @@ -606,6 +606,7 @@ private fun SnackBarStackItem(
}
}


val textPaddingValues =
if (model.actionText == null && model.trailingIcon != null) PaddingValues(
start = 16.dp,
Expand Down Expand Up @@ -786,24 +787,24 @@ private fun SnackBarStackItem(
)
}

if (model.trailingIcon != null && model.trailingIcon.isIconAvailable()) {
if (model.trailingIcon != null && model.trailingIcon!!.isIconAvailable()) {
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-null assertion operator !! is used here despite the null check immediately before. This is redundant and risky. Consider using smart casting by extracting the trailingIcon to a local variable after the null check, or use a safe call operator with let block to handle the non-null case.

Copilot uses AI. Check for mistakes.
Box(
modifier = Modifier
.testTag(SnackBarTestTags.SNACK_BAR_ICON)
.then(
if (model.trailingIcon.onClick != null) {
if (model.trailingIcon!!.onClick != null) {
Modifier.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(),
enabled = true,
role = Role.Image,
onClick = model.trailingIcon.onClick!!
onClick = model.trailingIcon!!.onClick!!
)
} else Modifier
)
) {
Icon(
model.trailingIcon,
model.trailingIcon!!,
Comment on lines +795 to +807
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple non-null assertion operators !! are used here and in lines 801 and 807. Since trailingIcon was already verified as non-null in line 790, Kotlin smart casting should work with a local variable. Refactor this code block to use a local variable or a let block to avoid the repeated use of !!.

Copilot uses AI. Check for mistakes.
modifier = Modifier
.padding(top = 12.dp, bottom = 12.dp, end = 16.dp)
.size(token.leftIconSize(snackBarInfo)),
Expand Down