Skip to content

[Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks#2151

Draft
Copilot wants to merge 2 commits into
devfrom
copilot/fix-ingestion-memory-errors
Draft

[Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks#2151
Copilot wants to merge 2 commits into
devfrom
copilot/fix-ingestion-memory-errors

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 18, 2026

Costs_transform_v1_0 and Costs_transform_v1_2 were hitting E_LOW_MEMORY_CONDITION during Data Factory pipeline ingestion due to unnecessary string allocation from using strcat() purely as an emptiness guard.

Changes

  • IngestionSetup_v1_0.kql / IngestionSetup_v1_2.kql: Replace the single strcat()-based check with individual isnotempty() predicates in the "populate missing prices" filter:
// Before — allocates a concatenated string just to check emptiness
and isnotempty(strcat(x_SkuMeterId, x_SkuOfferId))

// After — no allocation; also correctly requires both fields (matches the comment intent)
and isnotempty(x_SkuMeterId) and isnotempty(x_SkuOfferId)

The old form is semantically looser (true if either field is non-empty), while the price lookup key tmp_ReservationPriceLookupKey requires both — so the corrected form is also more precise. All other strcat() usages in these files are legitimate string construction and were left unchanged.

Copilot AI changed the title [WIP] Fix ingestion memory errors due to use of strcat [Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks May 18, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added Tool: FinOps hubs Data pipeline solution labels May 18, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Skill: KQL KQL queries and Data Explorer integration label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Skill: DevOps GitHub setup and automation Skill: Documentation Documentation updates Skill: KQL KQL queries and Data Explorer integration Tool: FinOps guide Implementing FinOps guide Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hubs] Ingestion memory errors due to use of strcat()

7 participants