[Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks#2151
Draft
Copilot wants to merge 2 commits into
Draft
[Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks#2151Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/ab35dd4d-dd87-400b-8550-60c4a73c71e3 Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ingestion memory errors due to use of strcat
[Hubs] Fix ingestion OOM errors by eliminating strcat() in emptiness checks
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Costs_transform_v1_0andCosts_transform_v1_2were hittingE_LOW_MEMORY_CONDITIONduring Data Factory pipeline ingestion due to unnecessary string allocation from usingstrcat()purely as an emptiness guard.Changes
IngestionSetup_v1_0.kql/IngestionSetup_v1_2.kql: Replace the singlestrcat()-based check with individualisnotempty()predicates in the "populate missing prices" filter:The old form is semantically looser (true if either field is non-empty), while the price lookup key
tmp_ReservationPriceLookupKeyrequires both — so the corrected form is also more precise. All otherstrcat()usages in these files are legitimate string construction and were left unchanged.