Conversation
Require branch names to be prefixed with the GitHub username (e.g., flanakin/my-feature) to match project conventions.
There was a problem hiding this comment.
Pull request overview
Updates the FinOps toolkit governance documentation and contributor metadata to reflect changes in governing board/advisory council membership and to document a branch naming convention.
Changes:
- Add Karl Kraft to the governing board (Finance external seat) and update vacant board seats to FinOps persona-aligned labels.
- Add Brad Watts to the advisory council (Azure Data Explorer seat) and reflect the update on the About page.
- Add branch naming convention guidance (prefix branches with GitHub username) and update all-contributors metadata.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/README.md | Updates the all-contributors table to include Karl Kraft as a governing board member. |
| docs-wiki/Governing-board.md | Updates board seat roster (adds Finance external; renames vacant external seats to personas). |
| docs-wiki/Advisory-council.md | Adds Azure Data Explorer seat and assigns Brad Watts. |
| docs-wiki/About.md | Updates board/council member tables to include Karl Kraft and Brad Watts. |
| README.md | Updates the all-contributors table to include Karl Kraft as a governing board member. |
| CLAUDE.md | Documents branch naming convention (prefix with GitHub username). |
| .all-contributorsrc | Adds Karl Kraft with the leader contribution type so generated contributor lists stay in sync. |
Comments suppressed due to low confidence (1)
docs-wiki/About.md:79
- The advisory council table is opened with
<table>but the section ends with</div>(and no</table>). This is invalid HTML and may cause the page layout/table to render incorrectly; close the table with</table>(and only close a<div>if one is opened).
<td align="center" valign="top" width="209"><a href="https://github.com/aromano2"><img src="https://avatars.githubusercontent.com/u/26576969?v=4?s=100" width="100px;" alt="Anthony Romano"/><br /><b>Anthony Romano</b></a><br /><sup>PowerShell</sup></td>
<td align="center" valign="top" width="209"><img src="https://github.com/microsoft/finops-toolkit/assets/399533/164afda4-1960-499d-a621-afdf6f868903" width="100px;" alt="Fernando Vasconcellos"/><br /><b>Fernando Vasconcellos</b></a><br /><sup>Learning resources</sup></td>
</tr>
</tbody>
</div>
| }, | ||
| { | ||
| "login": "kk09v", | ||
| "name": "Karl Kraft", |
There was a problem hiding this comment.
@kk09v I'm officially adding you to the governing board 🎉
@MSBrett @DirkBrinkmann @SCuffy @RolandKrummenacher please sign off on the PR to approve!
|
|
||
| | Seat | Member | | ||
| | ------------------------------------ | --------------------- | | ||
| | Azure Data Explorer | Brad Watts | |
There was a problem hiding this comment.
@bwatts64 Officially adding you to our Advisory Council 🎉 The governing board discussed and approved this earlier in the week. Happy to have you officially on board! 😊
- Close board and council tables with </table> instead of </div> - Remove stray </a> from Fernando Vasconcellos cell (no matching <a>) 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: copilot-pull-request-reviewer <copilot-pull-request-reviewer@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
|
🤖 [AI][Claude] PR Update Summary Addressed: 2 thread(s)
Fixed 3 pre-existing HTML issues in About.md: two |
🛠️ Description
Update governance structure across the toolkit:
📋 Checklist
🔬 How did you test this change?
📦 Deploy to test?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?