-
Notifications
You must be signed in to change notification settings - Fork 30
docs: Improve help text clarity and consistency across all commands #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Improve help text clarity and consistency across all commands #119
Conversation
- Updated core command descriptions for clarity and conciseness - Standardized terminology across all command groups - Improved auth commands: 'authenticate' instead of 'log in' - Simplified config commands with user-friendly language - Enhanced ACL commands with consistent formatting - Clarified job commands with 'asynchronously'/'synchronously' - Updated label commands to be more specific - Improved table commands with clearer actions - Updated command description constants in fab_constant.py - Applied UX writing best practices throughout Changes implement recommendations from UX writing analysis
|
@microsoft-github-policy-service agree company="Microsoft" |
PR Review: Help Text ImprovementsThanks for this contribution to improve CLI help text consistency! UX writing for command-line interfaces is often overlooked, and this PR addresses that well. 📚 Review ContextI reviewed this PR against established CLI design guidelines and industry patterns: Reference Materials:
Industry CLI Patterns Examined:
✅ What This PR Does Well
🔴 Required Changes
🟡 Recommended Changes
💡 Suggestions (Non-blocking)
📖 Key CLI Help Text Principles (for future reference)From clig.dev and industry standards:
Once the required changes are addressed, this is a solid improvement to the CLI's user experience! 🎉 |
…d commas - Restore 'Use with caution' warning for rm command (destructive action) - Add Oxford commas before 'or' in ACL description lists for consistency - Restore 'element or path' context in DESCRIBE_DESCRIPTION for discoverability - Keep 'Log in' for login (distinct from parent 'Authenticate with Fabric') - Restore 'Display active account and authentication state' for status command - Restore 'key' terminology in config commands for technical precision - Restore 'to a destination' in cp command to clarify two-arg semantics - Keep 'Retrieve the status' for run-list (preserves semantics) - Restore item type examples in run-sch for discoverability - Keep 'Vacuum' technical term for Delta Lake searchability
|
Thanks for the thorough review and the excellent CLI design resources! I've addressed all the feedback: ✅ Required Changes
✅ Recommended Changes
✅ Suggestions Implemented
Really appreciate the guidance on CLI UX patterns - especially the point about hierarchically distinct descriptions and keeping searchable technical terms. The clig.dev resource is great and adding it to my flow for future tasks. |
Summary
This PR implements comprehensive UX writing improvements to all user-facing help text in the Fabric CLI, making command descriptions more concise, consistent, and user-focused.
Changes Made
Core Commands (fab_commands.py)
Command Constants (fab_constant.py)
Parser Updates (6 files)
UX Writing Principles Applied
Testing
fab --helpfab auth --help, etc.)References