Skip to content

Conversation

@sophiatev
Copy link
Contributor

Summary

What changed?

This PR introduces throwing an InvalidOperationException when a purge is requested on an individual instance ID for an orchestration that is in an invalid runtime status (i.e. something non-terminal like "Running" or "Pending")

Why is this change needed?

I've run into a lot of customer issues recently related to attempting to purge running orchestrations.

Project checklist

  • Release notes are not required for the next release
    • Otherwise: Notes added to release_notes.md
  • Backport is not required
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • All required tests have been added/updated (unit tests, E2E tests)
  • Breaking change?
    • If yes:
      • Impact:
      • Migration guidance:

AI-assisted code disclosure (required)

Was an AI tool used? (select one)

  • No
  • Yes, AI helped write parts of this PR (e.g., GitHub Copilot)
  • Yes, an AI agent generated most of this PR

If AI was used:

  • Tool(s):
  • AI-assisted areas/files:
  • What you changed after AI output:

AI verification (required if AI was used):

  • I understand the code and can explain it
  • I verified referenced APIs/types exist and are correct
  • I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions)
  • I reviewed concurrency/async behavior
  • I checked for unintended breaking or behavior changes

Copilot AI review requested due to automatic review settings January 12, 2026 23:04
@sophiatev sophiatev changed the title first commit Throw an InvalidOperationException for purge requests on running orchestrations Jan 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Collaborator

@andystaples andystaples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sophiatev sophiatev merged commit 1bd7edb into main Jan 13, 2026
8 checks passed
@sophiatev sophiatev deleted the stevosyan/add-purge-runtime-status-check-support branch January 13, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants