Fix arq quoting to work in runInTerminal #1981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eleanorjboyd
approved these changes
Dec 9, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StellaHuang95
approved these changes
Dec 9, 2025
bschnurr
approved these changes
Dec 9, 2025
bschnurr
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runInTerminal has a special mode 'argsCanBeInterpretedByShell' that is set when extra arguments are being passed to the python script.
This mode causes VS code to run the arguments in the
runInTerminalrequest literally. Normally it quotes the arguments, but in this mode it just runs them as is.This causes #1980 because spaces are not quoted.
A related PR was submitted to the debugger extension: microsoft/vscode-python-debugger#886. That PR will add the
terminalQuoteCharacterthat this PR is using to try and set the quote to use around arguments.Fixes #1980