-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add data refresh capability for Python-based tables with automatic derived table regeneration #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
7b6fd1a
7d0570c
d8549c0
d45d762
e061014
f611d1f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need to update concept shelf, since it requires all columns are the same
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed concept shelf update from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect we should do this function as recalculate_derived_data, we need to sub functions:
decide which one to call based on whether the derived data is virtual or not in the backend. Call each table update independently (i.e., when a table update, we first find the list of derived table that are affected, and then for each affected table, gather their actual input data, and rerun code to get the new content and update) we don't need to do this recursively)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But for now, let's only do recalc_derived_data_py, as we first only support python data refresh. This simplifies the refresh logic for remote/duckdb data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to
recalculate_derived_dataendpoint withrecalc_derived_data_py()function. Virtual/SQL table support skipped - returns 'skipped' status. Each affected table is processed independently with actual input data. Fixed in commit f611d1f.