fix: Fix SFI issues and update Foundry Roles naming#856
Open
Ragini-Microsoft wants to merge 10 commits into
Open
fix: Fix SFI issues and update Foundry Roles naming#856Ragini-Microsoft wants to merge 10 commits into
Ragini-Microsoft wants to merge 10 commits into
Conversation
refactor: Updated Foundry Roles name
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the solution’s security posture and clarifies access guidance by adding jumpbox security log monitoring, tightening service authentication/encryption settings, and aligning “Foundry User” role naming across infra and developer docs/scripts.
Changes:
- Add a Data Collection Rule (DCR) to collect Windows Security events from the jumpbox and associate it with the VM when monitoring is enabled.
- Harden deployed resources by disabling local auth for Azure AI Search, enabling Storage infrastructure encryption, and enabling web app end-to-end encryption.
- Replace “Azure AI User” wording with “Foundry User” across infra comments, local dev scripts, and local dev documentation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/local_dev.sh | Updates local-dev role assignment messaging to “Foundry User”. |
| scripts/local_dev.ps1 | Updates local-dev role assignment messaging to “Foundry User”. |
| infra/modules/deploy_foundry_role_assignment.bicep | Updates role naming comments to “Foundry User” while keeping the same role definition ID. |
| infra/main.json | Regenerates the compiled ARM template to reflect new monitoring/encryption/auth settings. |
| infra/main.bicep | Adds jumpbox DCR + association via VM monitoring config; hardens Search/Storage/Web settings; updates role naming comments. |
| infra/main_custom.bicep | Adds jumpbox DCR + explicit association resource; hardens Search/Storage/Web settings; updates role naming comments. |
| docs/LocalDevelopmentSetup.md | Updates troubleshooting guidance and manual role assignment examples to “Foundry User”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| properties: { | ||
| dataCollectionRuleId: jumpboxDcr!.outputs.resourceId | ||
| description: 'Associates the Windows security event DCR with the jumpbox VM.' | ||
| } |
feat: Enhance email template, add RG owner tag, scalability input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several security and access improvements across the infrastructure and documentation, with a focus on enhancing monitoring, encryption, and clarifying the use of the "Foundry User" role (previously referred to as "Azure AI User"). The most significant updates include improved monitoring for jumpbox VMs, stricter authentication for services, and consistent naming for roles and documentation.
Security and Monitoring Enhancements:
infra/main.bicep,infra/main_custom.bicep) [1] [2]infra/main.bicep,infra/main_custom.bicep) [1] [2] [3] [4]Authentication and Access Control:
infra/main.bicep,infra/main_custom.bicep) [1] [2]Role Naming Consistency:
infra/main.bicep,infra/main_custom.bicep,infra/modules/deploy_foundry_role_assignment.bicep,scripts/local_dev.sh,scripts/local_dev.ps1,docs/LocalDevelopmentSetup.md) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]These changes collectively improve the security posture, monitoring capabilities, and maintain consistency in access management across the project.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation