fix: SFI issue fixes#854
Open
AjitPadhi-Microsoft wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Jumpbox Windows Security Event Log Data Collection Rule (DCR) configuration to (1) reduce collected event noise and (2) standardize the Log Analytics destination naming across the Bicep sources and the generated ARM template.
Changes:
- Updated the Windows Event Log
xPathQueriesfilter to excludeEventID4624. - Standardized the Log Analytics destination name via a single variable (
dcrLogAnalyticsDestinationName) and updated all references to use it. - Regenerated
infra/main.jsonto reflect the Bicep changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/main.bicep | Adds a destination-name variable for the Jumpbox DCR and updates the event XPath filter to exclude 4624. |
| infra/main_custom.bicep | Mirrors the same Jumpbox DCR destination naming and XPath filter updates as main.bicep. |
| infra/main.json | Regenerated template reflecting the updated XPath filter and destination naming variable usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
infra/main.bicep,infra/main_custom.bicep) and the generated ARM template (infra/main.json).Event log filtering improvements:
xPathQueriesfor security event log collection to exclude events withEventID4624, reducing noise by ignoring successful logon events. [1] [2] [3]Log Analytics destination standardization:
dcrLogAnalyticsDestinationName) to generate a consistent and descriptive name for Log Analytics destinations, replacing the previous hardcoded'laDestination'value. [1] [2] [3]Template consistency:
infra/main.json) to reflect the above changes, including the updatedtemplateHash.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information