fix(update): rename exe on Windows instead of detached process#47
Merged
fix(update): rename exe on Windows instead of detached process#47
Conversation
Replace the detached Popen approach with a rename-before-update trick: rename conductor.exe to conductor.exe.old before calling uv tool install. Windows allows renaming running executables, freeing the original path for uv to write the new binary. This gives full synchronous output identical to the Unix path, instead of silent background execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use importlib.metadata.version() so __version__ always matches pyproject.toml. Fixes version showing 0.1.0 after updating to 0.1.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Popenapproach with a rename-before-update trick for Windowsconductor updateconductor.exe→conductor.exe.oldbefore callinguv tool install, freeing the file lock souvcan write the new binary.oldfiles from previous updatesTest plan
make lintpassesmake typecheckpassesuv run pytest tests/test_cli/test_update.py -v— all 57 tests passuv run pytest— full suite passes (1748 passed)test/windows-update-fixbranch🤖 Generated with Claude Code