Skip to content

Conversation

@JamieMagee
Copy link
Member

This is a follow-up to #1548

@JamieMagee JamieMagee requested a review from a team as a code owner January 15, 2026 22:10
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.1%. Comparing base (6cdaa20) to head (917fcc3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...etectors/linux/Factories/DotnetComponentFactory.cs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1615   +/-   ##
=====================================
  Coverage   90.1%   90.1%           
=====================================
  Files        435     435           
  Lines      37357   37358    +1     
  Branches    2309    2309           
=====================================
+ Hits       33663   33667    +4     
+ Misses      3220    3217    -3     
  Partials     474     474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the integration of the DotnetComponentFactory by registering it in the LinuxScanner's component type lookup dictionary. The PR also applies formatting improvements to the DotnetComponentFactory class.

Changes:

  • Registers DotnetComponentFactory for ComponentType.NuGet in LinuxScanner's component type to factory mapping
  • Applies code formatting to method signature and return statement in DotnetComponentFactory

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.ComponentDetection.Detectors/linux/LinuxScanner.cs Adds ComponentType.NuGet mapping to DotnetComponentFactory in the componentTypeToFactoryLookup dictionary
src/Microsoft.ComponentDetection.Detectors/linux/Factories/DotnetComponentFactory.cs Reformats method signature and return statement for better readability

@JamieMagee JamieMagee merged commit 0071e78 into main Jan 15, 2026
32 of 34 checks passed
@JamieMagee JamieMagee deleted the users/jamagee/nuget-component-factory branch January 15, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants