Updating description for create_pull_request_thread#1270
Draft
krid-583 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_pull_request_threadin PR's, sometimes the tool collects the length of thesuggested_contentand marks the comment to that portion of the line which ends up being different from the user's intent.Example:
The offset used here is 13 even though the line's character length is 12.
Fix
Updated the description of parameter to consider both of this while finding the value of
RightEndFileOffsetGitHub issue number
1265
Associated Risks
✅ PR Checklist
🧪 How did you test it?
Manually tested by trying to tell it to add a suggestion comment.