Skip to content

Remove OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName#15390

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:RemoveOtlpEndpointEnvironmentVariableName
Mar 24, 2026
Merged

Remove OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName#15390
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:RemoveOtlpEndpointEnvironmentVariableName

Conversation

@eerhardt
Copy link
Copy Markdown
Member

Replace usages with KnownOtelConfigNames.ExporterOtlpEndpoint directly.

This change was only needed in main since it never made it to release/13.2.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15390

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15390"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName public field and updates internal OTLP env-var wiring to use KnownOtelConfigNames.ExporterOtlpEndpoint directly.

Changes:

  • Deleted OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName.
  • Updated OTLP endpoint environment variable setting/lookup to use KnownOtelConfigNames.ExporterOtlpEndpoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Aspire.Hosting/OtlpConfigurationExtensions.cs Removes the public env-var name field and writes OTEL_EXPORTER_OTLP_ENDPOINT using KnownOtelConfigNames.
src/Aspire.Hosting/Dcp/OtlpEndpointReferenceGatherer.cs Reads/writes the OTLP endpoint env var using KnownOtelConfigNames instead of the removed field.

Comment thread src/Aspire.Hosting/OtlpConfigurationExtensions.cs
@github-actions
Copy link
Copy Markdown
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Replace usages with KnownOtelConfigNames.ExporterOtlpEndpoint directly.

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
@eerhardt eerhardt force-pushed the RemoveOtlpEndpointEnvironmentVariableName branch from bcfc604 to a2068cf Compare March 24, 2026 14:03
@eerhardt eerhardt enabled auto-merge (squash) March 24, 2026 14:03
@github-actions
Copy link
Copy Markdown
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@eerhardt eerhardt merged commit 978c07f into microsoft:main Mar 24, 2026
493 of 496 checks passed
@eerhardt eerhardt deleted the RemoveOtlpEndpointEnvironmentVariableName branch March 24, 2026 15:02
@joperezr joperezr added this to the 13.3 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants