Remove OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName#15390
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15390Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15390" |
There was a problem hiding this comment.
Pull request overview
Removes the OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName public field and updates internal OTLP env-var wiring to use KnownOtelConfigNames.ExporterOtlpEndpoint directly.
Changes:
- Deleted
OtlpConfigurationExtensions.OtlpEndpointEnvironmentVariableName. - Updated OTLP endpoint environment variable setting/lookup to use
KnownOtelConfigNames.ExporterOtlpEndpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Aspire.Hosting/OtlpConfigurationExtensions.cs |
Removes the public env-var name field and writes OTEL_EXPORTER_OTLP_ENDPOINT using KnownOtelConfigNames. |
src/Aspire.Hosting/Dcp/OtlpEndpointReferenceGatherer.cs |
Reads/writes the OTLP endpoint env var using KnownOtelConfigNames instead of the removed field. |
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Replace usages with KnownOtelConfigNames.ExporterOtlpEndpoint directly. Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
bcfc604 to
a2068cf
Compare
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Replace usages with KnownOtelConfigNames.ExporterOtlpEndpoint directly.
This change was only needed in
mainsince it never made it torelease/13.2.