Skip to content

Python: Potential fix for code scanning alert no. 48: Clear-text logging of sensitive information #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moonbox3 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Python: Potential fix for code scanning alert no. 48: Clear-text logging of sensitive information #3633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/packages/declarative/agent_framework_declarative/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ def _try_powerfx_eval(value: str | None, log_value: bool = True) -> str | None:
return engine.eval(value[1:], symbols={"Env": dict(os.environ)})
except Exception as exc:
if log_value:
logger.debug(f"PowerFx evaluation failed for value '{value}': {exc}")
value_repr = value
else:
logger.debug(f"PowerFx evaluation failed for value (first five characters shown) '{value[:5]}': {exc}")
# Only log a small, non-sensitive snippet of the value when log_value is False
value_repr = value[:5]
logger.debug(f"PowerFx evaluation failed for value '{value_repr}': {exc}")
return value


Expand Down
Loading