.NET Purview Middleware: Improve Background Job Runner Injection #3256
+36
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoindoherty1
temporarily deployed
to
integration
GitHub Actions
Inactive
eoindoherty1
temporarily deployed
to
integration
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a dependency injection issue where BackgroundJobRunner was not being instantiated in certain circumstances, preventing background jobs from running. The fix makes PurviewWrapper directly depend on IBackgroundJobRunner instead of IChannelHandler, ensuring the background workers are always created.
Changes:
- Created new
IBackgroundJobRunnerinterface with aShutdownAsyncmethod - Changed
PurviewWrapperto depend onIBackgroundJobRunnerinstead ofIChannelHandler - Moved channel shutdown logic from
IChannelHandlerintoIBackgroundJobRunner.ShutdownAsync - Updated unit tests to use
IBackgroundJobRunnermock
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Purview/IBackgroundJobRunner.cs | New interface for background job management with ShutdownAsync method |
| dotnet/src/Microsoft.Agents.AI.Purview/BackgroundJobRunner.cs | Implements IBackgroundJobRunner and adds ShutdownAsync method that delegates to IChannelHandler |
| dotnet/src/Microsoft.Agents.AI.Purview/PurviewWrapper.cs | Updates dependency from IChannelHandler to IBackgroundJobRunner and calls ShutdownAsync on dispose |
| dotnet/src/Microsoft.Agents.AI.Purview/PurviewExtensions.cs | Registers BackgroundJobRunner as IBackgroundJobRunner in DI container |
| dotnet/tests/Microsoft.Agents.AI.Purview.UnitTests/PurviewWrapperTests.cs | Updates test mocks to use IBackgroundJobRunner instead of IChannelHandler |
eoindoherty1
temporarily deployed
to
integration
GitHub Actions
Inactive
eoindoherty1
temporarily deployed
to
integration
GitHub Actions
Inactive
Rishabh4275
approved these changes
Jan 16, 2026
darkness11111
approved these changes
Jan 16, 2026
dmytrostruk
approved these changes
Jan 16, 2026
alliscode
pushed a commit
to alliscode/agent-framework
that referenced
this pull request
Jan 16, 2026
…rosoft#3256) * Clean up background job dependency injection * Fix xml documentation grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The PurviewWrapper class does not directly depend on BackgroundJobRunner. This causes dependency injection to not instantiate BackgroundJobRunner in certain circumstances. Since BackgroundJobRunner creates the workers which process background jobs, this prevents jobs from running in the background. This change adds BackgroundJobRunner as a dependency of PurviewWrapper to ensure background workers are always created when the PurviewWrapper is created.
Description
This change is relatively small. It swaps the IChannelHandler dependency for IBackgroundJobRunner and moves the channel shutdown code from IChannelHandler into IBackgroundJobRunner.
Contribution Checklist