[1.8-stable CP] Fix: Deployment exceptions masked as ERROR_UNHANDLED_EXCEPTION; SetLastFailure logging single chars#6330
Open
agniuks wants to merge 6 commits intorelease/1.8-stablefrom
Open
Conversation
…stFailure logging single chars
agniuks
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Mar 24, 2026
Scottj1s
reviewed
Mar 24, 2026
Scottj1s
reviewed
Mar 24, 2026
| { | ||
| const HRESULT hr{ e.code() }; | ||
| const HRESULT hr = [&]() -> HRESULT { | ||
| if (WinAppSdk::Containment::IsChangeEnabled<WINAPPSDK_CHANGEID_61543987>()) |
Member
There was a problem hiding this comment.
this is trickier to separate out with containment, but I'm ok with this technique
Scottj1s
requested changes
Mar 24, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Mar 24, 2026
| } | ||
| else | ||
| { | ||
| m_lastFailure.file = std::wstring(1, *failure.pszFile); |
Member
There was a problem hiding this comment.
can't just leave original line?
Suggested change
| m_lastFailure.file = std::wstring(1, *failure.pszFile); | |
| m_lastFailure.file = *failure.pszFile; |
Contributor
Author
There was a problem hiding this comment.
oh yeah, that's bad! I need to draft up a containment skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP'ing: #6323