Display the wsl node in FolderPicker and FileSavePicker dialog navigation#6326
Draft
DinahK-2SO wants to merge 2 commits intomainfrom
Draft
Display the wsl node in FolderPicker and FileSavePicker dialog navigation#6326DinahK-2SO wants to merge 2 commits intomainfrom
DinahK-2SO wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The WSL navigation node (e.g.
\\wsl.localhost) is missing from the navigation pane ofFolderPickerandFileSavePickerdialogs. Users with WSL installed cannot browse to WSL file systems from these pickers without manually navigating to the\\wsl.localhostpaths.This is caused by undocumented behavior in the Windows Common Item Dialog:
IFileSaveDialog) never shows the WSL node in its navigation pane.IFileOpenDialogwithFOS_PICKFOLDERS) hides the WSL node regardless of whetherFOS_ALLOWMULTISELECTis set. TheFOS_FORCEFILESYSTEMoption (added in #5446 to prevent selection of invalid locations like "This PC") contributes to this, but is not the sole cause.FileOpenPicker(file mode, noFOS_PICKFOLDERS) is unaffected and already shows the WSL node.Fix
Manually insert the WSL root node into the dialog's navigation pane using
INameSpaceTreeControl::AppendRoot. A sharedIFileDialogEventshandler (PickerCommon::WslNavigationInserter) is registered on the dialog beforeShow(). On the firstOnFolderChange(when the dialog window just launched) callback it:INameSpaceTreeControlfrom the live dialog viaIServiceProvider→SID_STopLevelBrowser→IShellBrowser→INameSpaceTreeControl.\\wsl.localhost, falling back to\\wsl$).Cleanup (
CancelPendingInsertion) runs viawil::scope_exitafterShow()returns, cancelling any pending timer.The event handler registration (
Advise) usesSUCCEEDED()instead ofcheck_hresult()so that the picker still opens normally if registration fails.