Update sample for new functionalities of Storage.Picker APIs add in 2.0-exp2 by DinahK-2SO · Pull Request #582 · microsoft/WindowsAppSDK-Samples

DinahK-2SO · 2025-12-25T09:22:06Z

Update sample for new functionalities of Storage.Picker APIs add in 2.0-exp3:

FileOpenPicker.SuggestedStartFolder
FileOpenPicker.SuggestedFolder
FileOpenPIcker.FileTypeChoices
FileSavePicker.SuggestedStartFolder
FolderPicker.SuggestedStartFolder
FolderPicker.SuggestedFolder

DinahK-2SO · 2025-12-25T09:24:06Z

Samples/StoragePickers/cs-sample/FilePickersAppSinglePackaged.csproj

  </ItemGroup>
  <ItemGroup>
-    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.8.250907003" />
+    <PackageReference Include="Microsoft.WindowsAppSDK" Version="2.0.0-experimental3" />


TODO: change to exp4 after it's released.

haonanttt

It seems you need to rebase main first - there is already a merged PR to modify the packages.config version control to centralized package management, but your code is still with old packages.config mode

yeelam-gordon

Please fix according to latest vcxproj nuget package management.
Others looks good.

Copilot

Pull request overview

This PR updates the StoragePickers sample applications to demonstrate new functionalities added in WindowsAppSDK 2.0-experimental3, specifically for Storage.Picker APIs including FileOpenPicker, FileSavePicker, and FolderPicker.

Changes:

Added support for new picker properties: SuggestedStartFolder, SuggestedFolder, and FileTypeChoices
Implemented custom JSON deserialization methods to preserve insertion order for FileTypeChoices
Updated package references from WindowsAppSDK 1.8.x to 2.0.0-experimental3

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
Samples/StoragePickers/cs-sample/MainWindow.xaml.cs	Added DeserializeJson method and integrated new picker properties across FileOpenPicker, FileSavePicker, and FolderPicker
Samples/StoragePickers/cs-sample/MainWindow.xaml	Added UI controls for SuggestedStartFolder and SuggestedFolder, renamed FileTypeChoices controls for clarity
Samples/StoragePickers/cs-sample/FilePickersAppSinglePackaged.csproj	Updated WindowsAppSDK package reference to version 2.0.0-experimental3
Samples/StoragePickers/cpp-sample/MainWindow.xaml.h	Added method declarations for JSON deserialization and helper functions
Samples/StoragePickers/cpp-sample/MainWindow.xaml.cpp	Implemented JSON parsing logic for FileTypeChoices with insertion order preservation
Samples/StoragePickers/cpp-sample/MainWindow.xaml	Added OpenPickerFileTypeChoices controls and renamed SavePicker controls
Samples/StoragePickers/cpp-sample/packages.config	Updated all WindowsAppSDK and WebView2 package versions to 2.0.x-experimental
Samples/StoragePickers/cpp-sample/FilePickersAppSinglePackaged.vcxproj	Updated project import statements for new package versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T06:00:15Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

+                    var choicesJson = (string)OpenPickerFileTypeChoicesInput.Text;
+                    if (!string.IsNullOrEmpty(choicesJson))
+                    {
+                        foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))


Method name has a spelling error. The method name "DeserizlizeJsonWithInsertionOrder" should be "DeserializeJsonWithInsertionOrder" (missing 'ia' in 'serialize'). This is called on line 247.

Suggested change

foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))

foreach(var choice in DeserializeJsonWithInsertionOrder(choicesJson))

Copilot · 2026-01-12T06:00:15Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

                    {
-                        var choices = System.Text.Json.JsonSerializer.Deserialize(choicesJson, SourceGenerationContext.Default.DictionaryStringListString);
-                        if (choices != null)
+                        foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))


Method name has a spelling error. The method name "DeserizlizeJsonWithInsertionOrder" should be "DeserializeJsonWithInsertionOrder" (missing 'ia' in 'serialize'). This is called on line 308.

Suggested change

foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))

foreach (var choice in DeserializeJsonWithInsertionOrder(choicesJson))

Copilot · 2026-01-12T06:00:15Z

Samples/StoragePickers/cpp-sample/MainWindow.xaml.cpp

+
+    // This method parses the text input to preserve its insertion order.
+    // When developers coding with FileTypeChoices, the order can be directly reflected from code and this parsing is not required.
+    std::vector<std::pair<winrt::hstring, std::vector<winrt::hstring>>> MainWindow::DeserizeJsonInsertionOrder(std::wstring & jsonStr)


Method name has a spelling error. The method name "DeserizeJsonInsertionOrder" should be "DeserializeJsonInsertionOrder" (missing 'ial' in 'serialize').

Suggested change

std::vector<std::pair<winrt::hstring, std::vector<winrt::hstring>>> MainWindow::DeserizeJsonInsertionOrder(std::wstring & jsonStr)

std::vector<std::pair<winrt::hstring, std::vector<winrt::hstring>>> MainWindow::DeserializeJsonInsertionOrder(std::wstring & jsonStr)

Copilot · 2026-01-12T06:00:16Z

Samples/StoragePickers/cpp-sample/MainWindow.xaml.cpp

+                    }
+                    catch (winrt::hresult_error const& ex)
+                    {
+                        std::wstring message = L"Error in New FileSavePicker: Unable to parse FileTypeChoices JSON - ";


Error message is misleading. The error states "Error in New FileSavePicker" but this code is in the NewPickSingleFile_Click handler for FileOpenPicker, not FileSavePicker. The error message should indicate "Error in New FileOpenPicker" instead.

Suggested change

std::wstring message = L"Error in New FileSavePicker: Unable to parse FileTypeChoices JSON - ";

std::wstring message = L"Error in New FileOpenPicker: Unable to parse FileTypeChoices JSON - ";

Copilot · 2026-01-12T06:00:16Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

+                    var choicesJson = (string)OpenPickerFileTypeChoicesInput.Text;
+                    if (!string.IsNullOrEmpty(choicesJson))
+                    {
+                        foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))


Method name has a spelling error. The method name "DeserizlizeJsonWithInsertionOrder" should be "DeserializeJsonWithInsertionOrder" (missing 'ia' in 'serialize'). This is called on line 177.

Suggested change

foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))

foreach (var choice in DeserializeJsonWithInsertionOrder(choicesJson))

Copilot · 2026-01-12T06:00:18Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

                }

-                if (FileTypeChoicesCheckBox.IsChecked == true)
+                if (SavePickerFileTypeChoicesCheckBox.IsChecked == true)


The expression 'A == true' can be simplified to 'A'.

Copilot · 2026-01-12T06:00:19Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

                    picker.SuggestedStartLocation = GetSelectedNewLocationId();
                }

+                if (SuggestedStartFolderCheckBox.IsChecked == true)


The expression 'A == true' can be simplified to 'A'.

Copilot · 2026-01-12T06:00:19Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

+                    picker.SuggestedStartFolder = SuggestedStartFolderInput.Text;
+                }
+
+                if (SuggestedFolderCheckBox.IsChecked == true)


The expression 'A == true' can be simplified to 'A'.

Copilot · 2026-01-12T06:00:19Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

                    picker.SuggestedStartLocation = GetSelectedNewLocationId();
                }

+                if (SuggestedStartFolderCheckBox.IsChecked == true)


The expression 'A == true' can be simplified to 'A'.

Copilot · 2026-01-12T06:00:19Z

Samples/StoragePickers/cs-sample/MainWindow.xaml.cs

+                    picker.SuggestedStartFolder = SuggestedStartFolderInput.Text;
+                }
+
+                if (SuggestedFolderCheckBox.IsChecked == true)


The expression 'A == true' can be simplified to 'A'.

sample for new features in 2.0-exp3

98bf070

DinahK-2SO changed the base branch from main to release/experimental December 25, 2025 09:22

DinahK-2SO commented Dec 25, 2025

View reviewed changes

DinahK-2SO changed the title ~~Update sample for new functionalities of Storage.Picker APIs add in 2.0-exp3~~ Update sample for new functionalities of Storage.Picker APIs add in 2.0-exp2 Dec 25, 2025

haonanttt reviewed Jan 12, 2026

View reviewed changes

yeelam-gordon requested a review from Copilot January 12, 2026 05:52

Copilot started reviewing on behalf of yeelam-gordon January 12, 2026 05:52 View session

yeelam-gordon approved these changes Jan 12, 2026

View reviewed changes

Copilot AI reviewed Jan 12, 2026

View reviewed changes

	foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))
	foreach(var choice in DeserializeJsonWithInsertionOrder(choicesJson))

	foreach(var choice in DeserizlizeJsonWithInsertionOrder(choicesJson))
	foreach (var choice in DeserializeJsonWithInsertionOrder(choicesJson))

	std::vector<std::pair<winrt::hstring, std::vector<winrt::hstring>>> MainWindow::DeserizeJsonInsertionOrder(std::wstring & jsonStr)
	std::vector<std::pair<winrt::hstring, std::vector<winrt::hstring>>> MainWindow::DeserializeJsonInsertionOrder(std::wstring & jsonStr)

	std::wstring message = L"Error in New FileSavePicker: Unable to parse FileTypeChoices JSON - ";
	std::wstring message = L"Error in New FileOpenPicker: Unable to parse FileTypeChoices JSON - ";

Conversation

DinahK-2SO commented Dec 25, 2025

Uh oh!

DinahK-2SO Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

haonanttt left a comment

Choose a reason for hiding this comment

Uh oh!

yeelam-gordon left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants