Draft
Conversation
…86 A numeric comparison was attempted on $(TargetPlatformVersion)
…PreTranslateMessage
jeffstall
requested changes
Apr 26, 2024
Samples/Islands/cs-wpf-packaged/WpfWithIslandApp/WpfWithIslandApp.sln
Outdated
Show resolved
Hide resolved
JesseCol
changed the title
jeffstall
reviewed
May 2, 2024
| Changed_from_original_app: These packages are required for Lottie. | ||
| FIX BEFORE COMPLETING PR: These packages aren't currently publicly available. | ||
| --> | ||
| <PackageReference Include="CommunityToolkit.WinAppSDK.LottieIsland" Version="0.1.1-prerelease.2" /> |
Contributor
There was a problem hiding this comment.
@JesseCol, can you check with Geoffrey whether this is the correct Lottie NuGet package that he's assembled?
jeffstall
reviewed
May 2, 2024
| FIX BEFORE COMPLETING PR: These packages aren't currently publicly available. | ||
| --> | ||
| <PackageReference Include="CommunityToolkit.WinAppSDK.LottieIsland" Version="0.1.1-prerelease.2" /> | ||
| <PackageReference Include="CommunityToolkit.WinUI.Lottie" Version="8.0.230818-rc-FHL.4.gb41d8fdcc0" /> |
Contributor
There was a problem hiding this comment.
Same here. We don't want to pull in WinUI Lottie, just WinAppSDK.
jeffstall
reviewed
May 3, 2024
| is not set in this file: Microsoft.InteractiveExperiences.Common.targets | ||
| Changed_from_original_app | ||
| The lowest version of Windows that WinAppSDK supports is 17763. | ||
| But Lottie requires Windows 10.0.19041.0 or higher, so we target this one. |
Contributor
There was a problem hiding this comment.
@JesseCol, WinAppSDK Lottie only requires RS5 (the same as the rest of WASDK). Let's follow-up on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and/or which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Target Release
Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.
Checklist
/azp run SamplesCI-<FeatureName>to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.