Update Scenario1_BasicFunctionality.xaml.cs#965
Open
LanceMcCarthy wants to merge 1 commit intomicrosoft:mainfrom
Open
Update Scenario1_BasicFunctionality.xaml.cs#965LanceMcCarthy wants to merge 1 commit intomicrosoft:mainfrom
LanceMcCarthy wants to merge 1 commit intomicrosoft:mainfrom
Conversation
2239d7f to
9bf6501
Compare
Member
|
This isn't quite right, because you don't have to start the software trigger. The hardware trigger still works (and is recommended since it uses less power). Will need to add checkbox to select whether to scan continuously or to scan only when hardware trigger is pressed. |
Author
|
Thanks Raymond. Should I just add that to my branch? I can add the checkbox to enable/disable software scanning so we can keep it in this PR to maintain context. |
Member
|
I'll add this to the list of things for me to do (it's sort of already on the list, since it's an open PR). I'll need to port the sample to C++/WinRT first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem discussed in this documentation fix MicrosoftDocs/windows-dev-docs#681
The documentation has been updated, this sample should also be updated with the fix