Disable SDL codesign auto-scan on the package job#40657
Merged
Conversation
The Guardian CodeSign post-analysis scans the entire source checkout and flags every in-repo .ps1 as unsigned (17 errors, breaking the release build). Two prior attempts to filter the findings via the documented ob_sdl_codeSignValidation_excludes variable - at pipeline-level (b011cf7) and at the package job's variables block (PR #40653) - were both silently ignored. Disable the auto-scan on the package job; the msixbundle and nupkg outputs are explicitly signed AND verified by the EsrpCodeSigning tasks in the same job (SigntoolVerify / NuGetVerify operations), so signing coverage on the actual release artifacts is preserved. The build_x64 / build_arm64 jobs keep codesign validation enabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
force-pushed
the
fix/package-stage-disable-codesign
branch
from
f08b59c to
ce637ce
Compare
OneBlue
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OneBranch package stage to disable the SDL CodeSign post-analysis auto-scan only for the package job, addressing release failures caused by unsigned in-repo PowerShell helper scripts while preserving explicit signing/verification of release artifacts.
Changes:
- Replaces the ignored
.ps1CodeSign exclude withob_sdl_codeSignValidation_enabled: falsescoped to the package job. - Adds an inline YAML comment explaining why the package-job scan is disabled and noting that
msixbundleandnupkgoutputs are still signed and verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the OneBranch SDL CodeSign auto-scan on the
packagejob so it stops failing the release build on in-repo.ps1files.PR Checklist
Detailed Description
The Guardian CodeSign post-analysis scans the entire source checkout in the
packagejob and flags every in-repo.ps1as unsigned (17 errors), breaking the release build (most recently build 147990024).Two prior attempts to filter the findings via the documented
ob_sdl_codeSignValidation_excludesvariable were both silently ignored on this pipeline:wsl-build-{release,nightly,pr}-onebranch.ymland at job-level inbuild-job.yml.packagejob's ownvariables:block.After exhausting variable-format / scope / path-separator hypotheses without ADO log access, this PR takes the reliable route:
ob_sdl_codeSignValidationon thepackagejob only.build_x64/build_arm64jobs keep validation enabled.EsrpCodeSigning@5tasks in the same job (which runSigntoolVerify/NuGetVerifyoperations) - so signing coverage on the actual release artifacts is preserved; only the broken broad-tree scan is dropped.Validation Steps
Next release pipeline run will confirm the CodeSign post-analysis no longer fails the
packagejob.