Skip to content

Skip the 'TestAttachFailsWithoutWsl2Distro' test case if a WSL2 distro is installed#40456

Open
OneBlue wants to merge 1 commit intomasterfrom
user/oneblue/wsl1-test-fix-3
Open

Skip the 'TestAttachFailsWithoutWsl2Distro' test case if a WSL2 distro is installed#40456
OneBlue wants to merge 1 commit intomasterfrom
user/oneblue/wsl1-test-fix-3

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented May 7, 2026

Summary of the Pull Request

This prevents test failures when running this test locally with a wsl2 distro installed

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue OneBlue requested a review from a team as a code owner May 7, 2026 23:07
Copilot AI review requested due to automatic review settings May 7, 2026 23:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts a Windows mount test to avoid failing in developer environments where any WSL2 distribution is already installed, by conditionally skipping the WSL1-only validation scenario.

Changes:

  • Added a precondition to TestAttachFailsWithoutWsl2Distro that skips the test when any enumerated distro is not version 1 (i.e., a WSL2 distro is present).
  • Minor formatting fix at the end-of-namespace closing line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants