Enable Certificate download (.cer & .pfx)#648
Conversation
nchapagain001
force-pushed
the
users/nchapagain/EnableCertDownload
branch
from
f991c10 to
08a9050
Compare
Signed-off-by: Nirjan Chapagain <165215502+nchapagain001@users.noreply.github.com>
| "AccessTokenPath": "$.Parameters.LogFileName" | ||
| "AccessTokenPath": "$.Parameters.LogFileName", | ||
| "CertificateInstallationDir": "$.Parameters.CertificateInstallationDir", | ||
| "WithPrivateKey": "$.Parameters.WithPrivateKey" |
There was a problem hiding this comment.
No need to make a distinction. We have no scenarios where downloading a public key certificate is required for customer scenarios. Just assume the private key download.
| "CertificateName": "$.Parameters.CertificateName", | ||
| "AccessToken": "$.Parameters.AccessToken", | ||
| "AccessTokenPath": "$.Parameters.LogFileName" | ||
| "AccessTokenPath": "$.Parameters.LogFileName", |
There was a problem hiding this comment.
Naming: AccessTokenFilePath. It is longer but also more clear.
| @@ -14,9 +16,10 @@ | |||
| "KeyVaultUri": "$.Parameters.KeyVaultUri", | |||
There was a problem hiding this comment.
Note that I am doing some rework on the original implementation for Key Vault integration. It did not follow the patterns closely enough as we have for other types of stores (e.g. package, content, Event Hub). Because it didn't, it pushed wonky code choices/requirements downstream that are junking up the code.
We will need to converge together in the coming days to merge our changesets into something harmonious.
| @@ -0,0 +1,39 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT License. | |||
| namespace VirtualClient.Identity | |||
There was a problem hiding this comment.
I don't think we will need this class. This source code should just be located in the Component that is using it. If it is used in more than 1 Component, we should just use extension methods. The source code location/folder is fine. Maybe a CertificateManagerExtensions class.
3 participants
This PR adds a feature in bootstrap subcommand (&CertificateInstallation) to allow it to download certificate.
Removes ability to parse tenantId implicitly.