dehydrate: default to per-folder dehydration, add --full flag#1910
Open
tyrielv wants to merge 1 commit intomicrosoft:masterfrom
Open
dehydrate: default to per-folder dehydration, add --full flag#1910tyrielv wants to merge 1 commit intomicrosoft:masterfrom
tyrielv wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Change the default 'gvfs dehydrate' behavior from full-enlistment dehydration (unmount, backup entire src, recreate virtualization root) to per-folder dehydration of all root-level folders. This is faster and does not require a full unmount/remount cycle. The previous full-enlistment behavior is preserved via the new --full flag for cases where a complete reset is needed. Changes: - Add --full option for legacy full-enlistment dehydrate - When neither --folders nor --full is specified, enumerate all root-level directories from HEAD via 'git ls-tree' and dehydrate them individually - Using the git tree (not filesystem) ensures deleted folders are restored by the dehydrate - Reject combining --full with --folders - Update confirmation messages to reflect new defaults - Update functional tests: existing full-dehydrate tests now pass --full, add new FullDehydrate* tests, default-path test exercises the new all-root-folders behavior Performance (2.8M file repo, 1000 dirs hydrated, ~5,600 files): Root-folders (default): 13.0s Full (--full): 51.1s Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default 'gvfs dehydrate' behavior from full-enlistment dehydration (unmount, backup entire src, recreate virtualization root) to per-folder dehydration of all root-level folders. This is faster and does not require a full unmount/remount cycle.
The previous full-enlistment behavior is preserved via the new --full flag for cases where a complete reset is needed.
Changes:
Performance (2.8M file repo, 1000 dirs hydrated, ~5,600 files):
Root-folders (default): 13.0s
Full (--full): 51.1s