Fix GetHeadTreeId to only read head commit #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of GetHeadTreeId called "git show -s". "-s" suppresses the diff from the output, but it turns out git still performs the diff operation internally. The inefficiency isn't necessarily an issue, but we are running git.exe with the virtualization hook off so if the objects required for the diff are not already downloaded the command will fail. The new implementation produces the same output, but doesn't try to do a diff at all.
tyrielv
force-pushed
the
tyrielv/fix-head-tree-id
branch
from
2f1bd65 to
3cb5290
Compare
derrickstolee
approved these changes
Dec 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of GetHeadTreeId called "git show -s". "-s" suppresses the diff from the output, but it turns out git still performs the diff operation internally. The inefficiency isn't necessarily an issue, but we are running git.exe with the virtualization hook off so if the objects required for the diff are not already downloaded the command will fail.
The new implementation produces the same output, but doesn't try to do a diff at all.