Test that various Standard headers provide iterator range access functions #5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature test macro.
…cros and _HAS_CXX2a
tests/std/tests/GH_005968_headers_provide_begin_end/test_inplace_vector.cpp
Show resolved
Hide resolved
tests/std/tests/LWG3987_including_flat_foo_doesnt_provide_begin_end/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/LWG3987_including_flat_foo_doesnt_provide_begin_end/test_optional.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
NylteJ
reviewed
Dec 29, 2025
tests/std/tests/LWG3987_including_flat_foo_doesnt_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/LWG3987_including_flat_foo_doesnt_provide_begin_end/test_literator.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/test_flat_set.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/test_literator.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005968_headers_provide_begin_end/shared_test.hpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
changed the title
<flat_meow>.
StephanTLavavej
approved these changes
Jan 20, 2026
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
✅ ☑️ ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of changes that are remotely related to work on
<flat_meow>, but they are sufficiently self-contained that it would be nice to introduce them separately, before the feature branch is merged.Changes:
LWG3987_including_flat_foo_doesnt_provide_begin_endfor requirements of [iterator.range]/1 that certain headers introduce free functionsbegin/end/data/sizeetc. This test is required to prove proper implementation of LWG-3987 "Including<flat_foo>doesn't providestd::begin/end". Structure inspired byGH_000545_include_compare. Some notes:<valarray>test is deactivated with// TRANSITIONas it is blocked by Implement P3016R6 Resolve Inconsistencies Inbegin/endForvalarrayAnd Braced Initializer Lists #5847 (expected to accept soon)<flat_map>,<flat_set>,<optional>,<hive>and<inplace_vector>tests guarded by corresponding feature test macros; they will be activated by resolving P0429R9<flat_map>#2910, P1222R4<flat_set>#2912, P3168R2std::optionalRange Support #4772, P0447R28<hive>#5301 and P0843R14<inplace_vector>#4766, respectively.