Fix: Support bare multiplier words in English number recognition#3209
Open
BegBedion wants to merge 1 commit intomicrosoft:masterfrom
Open
Fix: Support bare multiplier words in English number recognition#3209BegBedion wants to merge 1 commit intomicrosoft:masterfrom
BegBedion wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Allow recognition of bare multiplier words like 'hundred', 'thousand', 'million', etc. without requiring a coefficient prefix. This enables patterns like 'hundred dollars' to be correctly recognized as 00. Previously only patterns with explicit coefficients were supported: - 'one hundred dollars' ✓ - 'a hundred dollars' ✓ - 'hundred dollars' ✗ (was not recognized) Fixes microsoft#3208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #3208 by allowing recognition of bare multiplier words like 'hundred', 'thousand', 'million', etc. without requiring an explicit coefficient prefix.
Problem
Previously, the English number recognizer only recognized multiplier words when prefixed with a coefficient:
This affected all NumberWithUnit models (Currency, Age, Temperature, etc.) since they depend on the Number extractor.
Solution
Modified the
SeparaIntRegexpattern inPatterns/English/English-Numbers.yamlto add support for standalone round number words by including an alternative option({RoundNumberIntegerRegex}).The pattern now supports three cases:
Changes
Patterns/English/English-Numbers.yaml- UpdatedSeparaIntRegexdefinitionTesting
This change should be tested with:
Closes #3208