[wip] Add better types to sr86x #7533
Open
+1,433
−693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
commented
Sep 29, 2025
| self.add_submodule(ch_name, data_channel) | ||
|
|
||
| self.add_submodule("data_channels", data_channels.to_channel_tuple()) | ||
| self.data_channels: ChannelTuple[SR86xDataChannel] = self.add_submodule( |
Collaborator
Author
There was a problem hiding this comment.
Perhaps the individual channels should also be declared statically similar to what was done in Keysight 33xxx drivers
jenshnielsen
commented
Sep 29, 2025
| ) | ||
| """ | ||
| T buffer readout. | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
The aux parameters could also be declared statically
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7533 +/- ##
==========================================
- Coverage 59.88% 58.89% -1.00%
==========================================
Files 352 353 +1
Lines 31843 31853 +10
==========================================
- Hits 19070 18760 -310
- Misses 12773 13093 +320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
force-pushed
the
sr66x_types
branch
from
530e230 to
cd9ae8d
Compare
jenshnielsen
force-pushed
the
sr66x_types
branch
from
cd9ae8d to
241271a
Compare
jenshnielsen
force-pushed
the
sr66x_types
branch
from
241271a to
d5bf566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.